Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1329303003: [Chromecast] Add cast_version_header dependency from CastSysInfoAndroid. (Closed)

Created:
5 years, 3 months ago by gunsch
Modified:
5 years, 3 months ago
Reviewers:
halliwell, kmackay
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Add cast_version_header dependency from CastSysInfoAndroid. CastSysInfoAndroid uses version.h, which is a build-time race. R=kmackay@chromium.org,halliwell@chromium.org BUG=None Committed: https://crrev.com/db501dffeca7f0b145d44c71cfc1ab57f50551a8 Cr-Commit-Position: refs/heads/master@{#348080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
gunsch
5 years, 3 months ago (2015-09-09 23:59:39 UTC) #1
kmackay
LGTM
5 years, 3 months ago (2015-09-10 00:02:21 UTC) #2
halliwell
On 2015/09/10 00:02:21, kmackay wrote: > LGTM lgtm
5 years, 3 months ago (2015-09-10 01:55:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329303003/1
5 years, 3 months ago (2015-09-10 02:46:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-10 02:52:04 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/db501dffeca7f0b145d44c71cfc1ab57f50551a8 Cr-Commit-Position: refs/heads/master@{#348080}
5 years, 3 months ago (2015-09-10 02:52:43 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db501dffeca7f0b145d44c71cfc1ab57f50551a8
Cr-Commit-Position: refs/heads/master@{#348080}

Powered by Google App Engine
This is Rietveld 408576698