Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1329273002: [tracing] Send smaps file desciptor to child process for tracing (Closed)

Created:
5 years, 3 months ago by ssid
Modified:
4 years, 10 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Send smaps file desciptor to child process for tracing The child processes cannot open the /proc/self/smaps due to the sandboxing. So, for tracing purpose the opened smaps file for child is sent to the child process via IPC. This file is closed when tracing is disabled. Note: The smaps file descriptor is sent only when tracing is enabled with "disabled-by-default-memory-infra" category and with a heavy dump trace config. See design doc: https://goo.gl/v7HgBC. Security concerns: Tracing can be enabled only by the user or an extension with "debugger" permission. When the user has enabled tracing manually, it is assumed that the renderers can be compromised. When tracing is enabled by a "debugger" extension, the user sees a pop up on each tab that the renderer is unsafe. See www.crbug.com/521686. This CL also sends descriptor of /proc/pid/status file for the child, so that the process can get its working set size. BUG=461788

Patch Set 1 #

Patch Set 2 : Nits. #

Patch Set 3 : Rebase and cleanup #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -49 lines) Patch
M base/trace_event/process_memory_maps_dump_provider.h View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M base/trace_event/process_memory_maps_dump_provider.cc View 1 2 3 3 chunks +6 lines, -7 lines 0 comments Download
M base/trace_event/process_memory_totals_dump_provider.h View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
M base/trace_event/process_memory_totals_dump_provider.cc View 1 2 3 2 chunks +36 lines, -14 lines 0 comments Download
M base/trace_event/trace_config.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M base/trace_event/trace_config.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M components/tracing/child_memory_dump_manager_delegate_impl.h View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M components/tracing/child_memory_dump_manager_delegate_impl.cc View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M components/tracing/child_trace_message_filter.cc View 1 2 4 chunks +5 lines, -7 lines 0 comments Download
M components/tracing/tracing_messages.h View 1 2 2 chunks +16 lines, -9 lines 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 1 2 2 chunks +35 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
ssid
1. Extending the std::istream is has too many methods. I can't find a better way ...
5 years, 3 months ago (2015-09-09 16:07:44 UTC) #2
ssid
Cleaned up code and rebased. PTAL.
5 years, 2 months ago (2015-10-06 13:05:51 UTC) #3
ssid
Made changes as discussed, WDYT?
5 years, 2 months ago (2015-10-08 09:41:00 UTC) #6
ssid
friendly reminder to review this patch, thanks
5 years, 2 months ago (2015-10-21 12:43:42 UTC) #8
Primiano Tucci (use gerrit)
On 2015/10/21 12:43:42, ssid wrote: > friendly reminder to review this patch, thanks Ok will ...
5 years, 2 months ago (2015-10-21 20:21:00 UTC) #9
Primiano Tucci (use gerrit)
5 years, 1 month ago (2015-11-05 11:03:58 UTC) #10
I think that given the new approach (dumping from browser)
this can be now closed, as we are not going to send any FD anymore, right?

Powered by Google App Engine
This is Rietveld 408576698