Source/web/WebLocalFrameImpl.cpp - Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use ScopedDisposal<T> Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/spellcheck/SpellChecker.cpp ('K') | « Source/core/editing/spellcheck/TextCheckingHelper.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/WebViewImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 5e2b49ed4ad94f60b53136cab1ed99bba2dc580d..2e944b02c0b224c0c0540378e1f36b121a1d65d7 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -256,6 +256,10 @@ static void frameContentAsPlainText(size_t maxChars, LocalFrame* frame, StringBu

// Select the document body.

RefPtrWillBeRawPtr<Range> range(document->createRange());

+#if ENABLE(OILPAN)

+ ScopedDisposal<Range> disposeScope(range);

+#endif

TrackExceptionState exceptionState;

range->selectNodeContents(document->body(), exceptionState);

« Source/core/editing/spellcheck/SpellChecker.cpp ('K') | « Source/core/editing/spellcheck/TextCheckingHelper.cpp ('k') | Source/web/WebViewImpl.cpp » ('j') | Source/web/WebViewImpl.cpp » ('J')