Source/core/editing/spellcheck/SpellCheckRequester.cpp - Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/spellcheck/SpellCheckRequester.cpp

Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use ScopedDisposal<T> Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/VisibleSelection.cpp ('K') | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/editing/spellcheck/SpellChecker.h » ('j') | Source/core/editing/spellcheck/SpellChecker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/spellcheck/SpellCheckRequester.cpp

diff --git a/Source/core/editing/spellcheck/SpellCheckRequester.cpp b/Source/core/editing/spellcheck/SpellCheckRequester.cpp

index a5a99b8e2d641440ee7c76e0e59982527298ba69..72ac599b4850f1ba3f0ad9aa3f7a6d4306fdd69d 100644

--- a/Source/core/editing/spellcheck/SpellCheckRequester.cpp

+++ b/Source/core/editing/spellcheck/SpellCheckRequester.cpp

@@ -251,6 +251,12 @@ void SpellCheckRequester::didCheck(int sequence, const Vector<TextCheckingResult

if (m_lastProcessedSequence < sequence)

m_lastProcessedSequence = sequence;

+ // This assumes that m_processingRequest's Ranges aren't shared.

yosin_UTC9 2015/09/10 06:37:04 It is better to move |dispose()| call to |clear()|

+ if (m_processingRequest->checkingRange())

+ m_processingRequest->checkingRange()->dispose();

+ if (m_processingRequest->paragraphRange())

+ m_processingRequest->paragraphRange()->dispose();

m_processingRequest.clear();

if (!m_requestQueue.isEmpty())

m_timerToProcessQueuedRequest.startOneShot(0, FROM_HERE);