Source/core/editing/InputMethodController.cpp - Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/InputMethodController.cpp

Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use ScopedDisposal<T> Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/InputMethodController.cpp

diff --git a/Source/core/editing/InputMethodController.cpp b/Source/core/editing/InputMethodController.cpp

index 3c695f1e8270c7f1baf763f8e3825d031e9a2993..3c5a07856361785edbd4baa11e8cd1ed54481617 100644

--- a/Source/core/editing/InputMethodController.cpp

+++ b/Source/core/editing/InputMethodController.cpp

@@ -359,12 +359,12 @@ PassRefPtrWillBeRawPtr<Range> InputMethodController::compositionRange() const

PlainTextRange InputMethodController::getSelectionOffsets() const

{

- RefPtrWillBeRawPtr<Range> range = firstRangeOf(frame().selection().selection());

- if (!range)

+ EphemeralRange range = firstEphemeralRangeOf(frame().selection().selection());

yosin_UTC9 2015/09/10 06:37:03 nit: |const EphmeralRange|

+ if (range.isNull())

return PlainTextRange();

ContainerNode* editable = frame().selection().rootEditableElementOrTreeScopeRootNode();

ASSERT(editable);

- return PlainTextRange::create(*editable, *range.get());

+ return PlainTextRange::create(*editable, range);

}

bool InputMethodController::setSelectionOffsets(const PlainTextRange& selectionOffsets)

« no previous file with comments | « Source/core/dom/Range.cpp ('k') | Source/core/editing/VisibleSelection.h » ('j') | Source/core/editing/VisibleSelection.cpp » ('J')