Source/core/editing/spellcheck/SpellChecker.h - Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/spellcheck/SpellChecker.h

Issue 1329253002: WIP: prefer using EphemeralRange for SpellChecker. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: introduce Range::dispose() Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/VisibleSelection.cpp ('K') | « Source/core/editing/spellcheck/SpellCheckRequester.cpp ('k') | Source/core/editing/spellcheck/SpellChecker.cpp » ('j') | Source/core/editing/spellcheck/SpellChecker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/spellcheck/SpellChecker.h

diff --git a/Source/core/editing/spellcheck/SpellChecker.h b/Source/core/editing/spellcheck/SpellChecker.h

index aa242b59e2f5c256c242408a940f13dadb6b2caf..53a13a0f29506060b18dfbf53c7ed8825f62c206 100644

--- a/Source/core/editing/spellcheck/SpellChecker.h

+++ b/Source/core/editing/spellcheck/SpellChecker.h

@@ -107,7 +107,7 @@ private:

bool unifiedTextCheckerEnabled() const;

void chunkAndMarkAllMisspellingsAndBadGrammar(TextCheckingTypeMask textCheckingOptions, const TextCheckingParagraph& fullParagraphToCheck, bool asynchronous);

- void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask textCheckingOptions, Range* checkingRange, Range* paragraphRange, bool asynchronous, int requestNumber, int* checkingLength = 0);

+ void markAllMisspellingsAndBadGrammarInRanges(TextCheckingTypeMask textCheckingOptions, const EphemeralRange& checkingRange, const EphemeralRange& paragraphRange, bool asynchronous, int requestNumber, int* checkingLength = 0);

RawPtrWillBeMember<LocalFrame> m_frame;

const OwnPtrWillBeMember<SpellCheckRequester> m_spellCheckRequester;