WIP: prefer using EphemeralRange for SpellChecker.

Source/core/editing/spellcheck/TextCheckingHelper.h

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #ifndef TextCheckingHelper_h
 #define TextCheckingHelper_h
 
+#include "core/editing/EphemeralRange.h"
 #include "core/editing/Position.h"
 #include "platform/heap/Handle.h"
 #include "platform/text/TextChecking.h"
 #include "wtf/text/WTFString.h"
 
 namespace blink {
 
 class ExceptionState;
 class LocalFrame;
 class Range;
 class SpellCheckerClient;
 class TextCheckerClient;
 struct TextCheckingResult;
 
 class TextCheckingParagraph {
     STACK_ALLOCATED();
 public:
-    explicit TextCheckingParagraph(PassRefPtrWillBeRawPtr<Range> checkingRange);
+    explicit TextCheckingParagraph(const EphemeralRange checkingRange);
+    TextCheckingParagraph(const EphemeralRange checkingRange, const EphemeralRange paragraphRange);
     TextCheckingParagraph(PassRefPtrWillBeRawPtr<Range> checkingRange, PassRefPtrWillBeRawPtr<Range> paragraphRange);
     ~TextCheckingParagraph();
 
     int rangeLength() const;
-    PassRefPtrWillBeRawPtr<Range> subrange(int characterOffset, int characterCount) const;
+    EphemeralRange subrange(int characterOffset, int characterCount) const;
     int offsetTo(const Position&, ExceptionState&) const;
     void expandRangeToNextEnd();
 
     const String& text() const;
     // Why not let clients call these functions on text() themselves?
     String textSubstring(unsigned pos, unsigned len = INT_MAX) const { return text().substring(pos, len); }
     UChar textCharAt(int index) const { return text()[static_cast<unsigned>(index)]; }
 
     bool isEmpty() const;
     bool isTextEmpty() const { return text().isEmpty(); }
     bool isRangeEmpty() const { return checkingStart() >= checkingEnd(); }
 
     int checkingStart() const;
     int checkingEnd() const;
     int checkingLength() const;
 
     bool checkingRangeCovers(int location, int length) const { return location < checkingEnd() && location + length > checkingStart(); }
-    PassRefPtrWillBeRawPtr<Range> paragraphRange() const;
-    PassRefPtrWillBeRawPtr<Range> checkingRange() const { return m_checkingRange; }
+    EphemeralRange paragraphRange() const;
+    EphemeralRange checkingRange() const { return m_checkingRange; }
+    void setParagraphRange(const EphemeralRange&);
 
 private:
     void invalidateParagraphRangeValues();
-    PassRefPtrWillBeRawPtr<Range> offsetAsRange() const;
+    EphemeralRange offsetAsRange() const;
 
-    RefPtrWillBeMember<Range> m_checkingRange;
-    mutable RefPtrWillBeMember<Range> m_paragraphRange;
-    mutable RefPtrWillBeMember<Range> m_offsetAsRange;
+    EphemeralRange m_checkingRange;
+    mutable EphemeralRange m_paragraphRange;

[yosin_UTC9, 2015/09/10 01:58:39]

Good catch!

Since, |EphmeralRange| checks DOM tree version, we can detect miss use
of |TextCheckingParagraph|, e.g. mutate DOM tree during
|TextCheckingParagaph| instances alive.

+    mutable EphemeralRange m_offsetAsRange;
     mutable String m_text;
     mutable int m_checkingStart;
     mutable int m_checkingEnd;
     mutable int m_checkingLength;
 };
 
 class TextCheckingHelper {
     WTF_MAKE_NONCOPYABLE(TextCheckingHelper);
     STACK_ALLOCATED();
 public:
     TextCheckingHelper(SpellCheckerClient&, const Position& start, const Position& end);
     ~TextCheckingHelper();
 
     String findFirstMisspelling(int& firstMisspellingOffset, bool markAll, RefPtrWillBeRawPtr<Range>& firstMisspellingRange);
     String findFirstMisspellingOrBadGrammar(bool checkGrammar, bool& outIsSpelling, int& outFirstFoundOffset, GrammarDetail& outGrammarDetail);
     String findFirstBadGrammar(GrammarDetail& outGrammarDetail, int& outGrammarPhraseOffset, bool markAll);
     void markAllMisspellings(RefPtrWillBeRawPtr<Range>& firstMisspellingRange);
     void markAllBadGrammar();
 
 private:
     SpellCheckerClient* m_client;
     Position m_start;
     Position m_end;
 
     int findFirstGrammarDetail(const Vector<GrammarDetail>& grammarDetails, int badGrammarPhraseLocation, int startOffset, int endOffset, bool markAll) const;
     bool unifiedTextCheckerEnabled() const;
 };
 
 void checkTextOfParagraph(TextCheckerClient&, const String&, TextCheckingTypeMask, Vector<TextCheckingResult>&);
-void expandRangeToSentenceBoundary(Range&);
+EphemeralRange expandRangeToSentenceBoundary(const EphemeralRange&);
 bool unifiedTextCheckerEnabled(const LocalFrame*);
 
 } // namespace blink
 
 #endif // TextCheckingHelper_h