WIP: prefer using EphemeralRange for SpellChecker.

Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 205 matching lines @@
     return m_startInComposedTree;
 }
 
 PositionInComposedTree VisibleSelection::endInComposedTree() const
 {
     return m_endInComposedTree;
 }
 
 PassRefPtrWillBeRawPtr<Range> firstRangeOf(const VisibleSelection& selection)
 {
     if (selection.isNone())

[yosin_UTC9, 2015/09/10 01:58:39]

nit: Could you use |firstEphemeralRange()| here?

return createRange(firstEphemeralRangeOf(seleciton));

and add TODO to replace |firstRangeOf()| to above pattern.

[yosin_UTC9, 2015/09/10 02:24:02]

It is better to remove |firstRangeOf()| by replacing it to
|createRange(firstEphemeralRange(selection))

There are 30 call sites of |firstRangeOf()|, but 18 sites are
in test.

         return nullptr;
     Position start = selection.start().parentAnchoredEquivalent();
     Position end = selection.end().parentAnchoredEquivalent();
     return Range::create(*start.document(), start, end);
 }
 
+EphemeralRange firstEphemeralRangeOf(const VisibleSelection& selection)
+{
+    if (selection.isNone())
+        return EphemeralRange();
+    Position start = selection.start().parentAnchoredEquivalent();
+    Position end = selection.end().parentAnchoredEquivalent();
+    return EphemeralRange(start, end);
+}
+
 EphemeralRange VisibleSelection::toNormalizedEphemeralRange() const
 {
     if (isNone())
         return EphemeralRange();
 
     // Make sure we have an updated layout since this function is called
     // in the course of running edit commands which modify the DOM.
     // Failing to call this can result in equivalentXXXPosition calls returning
     // incorrect results.
     m_start.document()->updateLayout();
@@ skipping 977 matching lines @@
     sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
 }
 
 #endif