Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 132923002: Disable unit tests that fail on cros. (Closed)

Created:
6 years, 11 months ago by achuithb
Modified:
6 years, 11 months ago
Reviewers:
dtu, Tim Song
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@oobe
Visibility:
Public.

Description

Disable unit tests that fail on cros. Some of these tests need to be fixed and others should probably stay disabled. BUG=331940 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244307

Patch Set 1 #

Patch Set 2 : also testVersionDetectio #

Patch Set 3 : presubmit tests #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M tools/perf/page_sets/presubmit_unittest.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py View 9 chunks +14 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_console_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_memory_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/inspector_page_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/browser_unittest.py View 1 2 chunks +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/tab_unittest.py View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/click_element_unittest.py View 4 chunks +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/loop_unittest.py View 4 chunks +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/navigate_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/play_unittest.py View 8 chunks +8 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/seek_unittest.py View 5 chunks +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/wait_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
achuithb
Tim, please take a look.
6 years, 11 months ago (2014-01-10 00:27:08 UTC) #1
Tim Song
lgtm
6 years, 11 months ago (2014-01-10 00:43:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/132923002/80001
6 years, 11 months ago (2014-01-10 01:25:31 UTC) #3
commit-bot: I haz the power
Failed to apply patch for tools/perf/page_sets/presubmit_unittest.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-10 01:25:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/132923002/130001
6 years, 11 months ago (2014-01-10 20:54:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44393
6 years, 11 months ago (2014-01-10 21:43:27 UTC) #6
achuithb
Dave: could I get an owner lgtm for tools/perf?
6 years, 11 months ago (2014-01-10 21:45:51 UTC) #7
dtu
lgtm
6 years, 11 months ago (2014-01-10 22:30:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/132923002/130001
6 years, 11 months ago (2014-01-10 23:40:14 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 02:14:12 UTC) #10
Message was sent while issue was closed.
Change committed as 244307

Powered by Google App Engine
This is Rietveld 408576698