Issue 1329133002: Fix AstPrinter::VisitCallRuntime to not print garbage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1329133002: Fix AstPrinter::VisitCallRuntime to not print garbage. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger

Modified:
5 years, 3 months ago

Reviewers:
Benedikt Meurer, Yang

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix AstPrinter::VisitCallRuntime to not print garbage. R=bmeurer@chromium.org Committed: https://crrev.com/e615c03ba19057a1d40ccd90ac2071863528d804 Cr-Commit-Position: refs/heads/master@{#30633}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/prettyprinter.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yang

On 2015/09/08 11:11:21, Michael Starzinger wrote: > Benedikt: PTAL > Yang: FYI lgtm

5 years, 3 months ago (2015-09-08 11:42:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329133002/1

5 years, 3 months ago (2015-09-08 12:38:04 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 12:39:41 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e615c03ba19057a1d40ccd90ac2071863528d804
Cr-Commit-Position: refs/heads/master@{#30633}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages