Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 132913011: Include the MSan interface header in base/compiler_specific.h. (Closed)

Created:
6 years, 10 months ago by earthdok
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai, eugenis
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Include the MSan interface header in base/compiler_specific.h. Since that header is now available in Chrome, we can include it instead of re-defining the interface. Also, the definition of __msan_unpoison() in base/compiler_specific.h conflicted with the definition in sanitizer/msan_interface.h, preventing us from including the interface header anywhere (e.g. during debugging). BUG=178409 R=eugenis@chromium.org, mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/compiler_specific.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
earthdok
ptal
6 years, 10 months ago (2014-02-03 15:08:37 UTC) #1
eugenis
lgtm
6 years, 10 months ago (2014-02-03 15:36:03 UTC) #2
earthdok
Mark, PTAL
6 years, 10 months ago (2014-02-03 16:01:18 UTC) #3
Mark Mentovai
LGTM
6 years, 10 months ago (2014-02-03 16:49:06 UTC) #4
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 10 months ago (2014-02-03 16:51:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/132913011/1
6 years, 10 months ago (2014-02-03 16:52:07 UTC) #6
commit-bot: I haz the power
Change committed as 248555
6 years, 10 months ago (2014-02-03 19:51:22 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 19:51:28 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 19:51:28 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698