Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 132913010: Update V8 to version 3.24.30.1 (based on bleeding_edge revision r19017). (Closed)

Created:
6 years, 10 months ago by Michael Achenbach
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Update V8 to version 3.24.30.1 (based on bleeding_edge revision r19017). Includes test expectation changes for changed V8 compiler message. TBR=hpayer@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/error_console/error_console_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 10 months ago (2014-02-03 15:00:23 UTC) #1
Michael Achenbach
FYI
6 years, 10 months ago (2014-02-03 15:00:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/132913010/1
6 years, 10 months ago (2014-02-03 15:00:36 UTC) #3
Hannes Payer (out of office)
LGTM
6 years, 10 months ago (2014-02-03 15:10:41 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 17:37:31 UTC) #5
commit-bot: I haz the power
Change committed as 248514
6 years, 10 months ago (2014-02-03 17:37:31 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 17:37:36 UTC) #7
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698