Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Unified Diff: Source/core/rendering/RenderView.h

Issue 132913002: Harden the machinery around updateWidgetPositions() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add FIXME Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderView.h
diff --git a/Source/core/rendering/RenderView.h b/Source/core/rendering/RenderView.h
index 99c7ae7253b87a57a6c92f6dcd6e7a99f4051103..d45a08fb869b55a7035b501579b73e48c07fbe66 100644
--- a/Source/core/rendering/RenderView.h
+++ b/Source/core/rendering/RenderView.h
@@ -35,7 +35,6 @@ namespace WebCore {
class FlowThreadController;
class RenderLayerCompositor;
class RenderQuote;
-class RenderWidget;
// The root of the render tree, corresponding to the CSS initial containing block.
// It's dimensions match that of the logical viewport (which may be different from
@@ -109,10 +108,6 @@ public:
virtual LayoutRect viewRect() const OVERRIDE;
- void updateWidgetPositions();
- void addWidget(RenderWidget*);
- void removeWidget(RenderWidget*);
-
// layoutDelta is used transiently during layout to store how far an object has moved from its
// last layout location, in order to repaint correctly.
// If we're doing a full repaint m_layoutState will be 0, but in that case layoutDelta doesn't matter.
@@ -258,9 +253,6 @@ private:
void positionDialog(RenderBox*);
void positionDialogs();
- size_t getRetainedWidgets(Vector<RenderWidget*>&);
- void releaseWidgets(Vector<RenderWidget*>&);
-
void pushLayoutStateForCurrentFlowThread(const RenderObject*);
void popLayoutStateForCurrentFlowThread();
@@ -280,9 +272,6 @@ private:
int m_maximalOutlineSize; // Used to apply a fudge factor to dirty-rect checks on blocks/tables.
int m_oldMaximalOutlineSize; // The fudge factor from the previous layout.
- typedef HashSet<RenderWidget*> RenderWidgetSet;
- RenderWidgetSet m_widgets;
-
LayoutUnit m_pageLogicalHeight;
bool m_pageLogicalHeightChanged;
LayoutState* m_layoutState;
« no previous file with comments | « Source/core/rendering/RenderLayerScrollableArea.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698