Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: Source/core/frame/FrameView.h

Issue 132913002: Harden the machinery around updateWidgetPositions() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add FIXME Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.h
diff --git a/Source/core/frame/FrameView.h b/Source/core/frame/FrameView.h
index 5cad0ffd0f641d3dd12179b6c3beb37bcd44635a..66c9cf1add90621f93cae9fea6046d00dabd1a2e 100644
--- a/Source/core/frame/FrameView.h
+++ b/Source/core/frame/FrameView.h
@@ -50,6 +50,7 @@ class RenderEmbeddedObject;
class RenderObject;
class RenderScrollbarPart;
class RenderStyle;
+class RenderWidget;
Pagination::Mode paginationModeForRenderStyle(RenderStyle*);
@@ -211,6 +212,10 @@ public:
bool safeToPropagateScrollToParent() const { return m_safeToPropagateScrollToParent; }
void setSafeToPropagateScrollToParent(bool isSafe) { m_safeToPropagateScrollToParent = isSafe; }
+ void addWidget(RenderWidget*);
+ void removeWidget(RenderWidget*);
+ void updateWidgetPositions();
+
void addWidgetToUpdate(RenderEmbeddedObject&);
virtual void paintContents(GraphicsContext*, const IntRect& damageRect) OVERRIDE;
@@ -458,6 +463,9 @@ private:
typedef HashSet<RefPtr<RenderEmbeddedObject> > EmbeddedObjectSet;
EmbeddedObjectSet m_widgetUpdateSet;
+ // FIXME: These are just "children" of the FrameView and should be RefPtr<Widget> instead.
+ HashSet<RefPtr<RenderWidget> > m_widgets;
+
RefPtr<Frame> m_frame;
bool m_doFullRepaint;
« no previous file with comments | « no previous file | Source/core/frame/FrameView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698