Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1329043002: [turbofan] Clarify comment about Parameter indexing. (Closed)

Created:
5 years, 3 months ago by Michael Starzinger
Modified:
5 years, 3 months ago
Reviewers:
oth, rmcilroy
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Clarify comment about Parameter indexing. This clarifies a comments in the AstGraphBuilder that has led to confusion about what "parameter index" refers to. The off-by-one is confusing and a terribly phrased comment doesn't make it any better. R=rmcilroy@chromium.org,oth@chromium.org Committed: https://crrev.com/b48e0c4a589ab6fa9f0d91012d437043e70f7622 Cr-Commit-Position: refs/heads/master@{#30616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/compiler/ast-graph-builder.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 3 months ago (2015-09-07 08:58:38 UTC) #1
oth
On 2015/09/07 08:58:38, Michael Starzinger wrote: Thanks Michael. LGTM.
5 years, 3 months ago (2015-09-07 09:02:00 UTC) #2
rmcilroy
Ahh yes, it was the variable indexes which had the '-1', that explains my confusion. ...
5 years, 3 months ago (2015-09-07 09:10:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1329043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1329043002/1
5 years, 3 months ago (2015-09-07 09:12:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 09:37:06 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 09:37:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b48e0c4a589ab6fa9f0d91012d437043e70f7622
Cr-Commit-Position: refs/heads/master@{#30616}

Powered by Google App Engine
This is Rietveld 408576698