Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/browser/chromeos/drive/change_list_loader_unittest.cc

Issue 132903008: drive: Implement lock mechanism to ChangeListLoader (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/drive/change_list_loader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/change_list_loader_unittest.cc
diff --git a/chrome/browser/chromeos/drive/change_list_loader_unittest.cc b/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
index ab0bb746b7a148a639be42a162ffe0ee5dd9bf03..43ac971ca606c682617fa1c2c67d3c8e9563cb19 100644
--- a/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
+++ b/chrome/browser/chromeos/drive/change_list_loader_unittest.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/chromeos/drive/change_list_loader.h"
+#include "base/callback_helpers.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/scoped_ptr.h"
#include "base/prefs/testing_pref_service.h"
@@ -427,5 +428,37 @@ TEST_F(ChangeListLoaderTest, CheckForUpdates) {
metadata_->GetResourceEntryByPath(new_file_path, &entry));
}
+TEST_F(ChangeListLoaderTest, Lock) {
+ FileError error = FILE_ERROR_FAILED;
+ change_list_loader_->LoadForTesting(
+ google_apis::test_util::CreateCopyResultCallback(&error));
+ base::RunLoop().RunUntilIdle();
+ EXPECT_EQ(FILE_ERROR_OK, error);
+
+ // Add a new file.
+ scoped_ptr<google_apis::ResourceEntry> file = AddNewFile("New File");
+ ASSERT_TRUE(file);
+
+ // Lock the loader.
+ scoped_ptr<base::ScopedClosureRunner> lock = change_list_loader_->GetLock();
+
+ // Start update.
+ TestChangeListLoaderObserver observer(change_list_loader_.get());
+ FileError check_for_updates_error = FILE_ERROR_FAILED;
+ change_list_loader_->CheckForUpdates(
+ google_apis::test_util::CreateCopyResultCallback(
+ &check_for_updates_error));
+ base::RunLoop().RunUntilIdle();
+
+ // Update is pending due to the lock.
+ EXPECT_TRUE(observer.changed_directories().empty());
+
+ // Unlock the loader, this should resume the pending udpate.
+ lock.reset();
+ base::RunLoop().RunUntilIdle();
+ EXPECT_EQ(1U, observer.changed_directories().count(
+ util::GetDriveMyDriveRootPath()));
+}
+
} // namespace internal
} // namespace drive
« no previous file with comments | « chrome/browser/chromeos/drive/change_list_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698