Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 132903008: drive: Implement lock mechanism to ChangeListLoader (Closed)

Created:
6 years, 11 months ago by hashimoto
Modified:
6 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

drive: Implement lock mechanism to ChangeListLoader ChangeListLoader should be locked while EntryUpdatePerformer is creating a new entry on the server. Otherwise, it may recieve a change list which contains the new entry and confuse the sync mechanism. BUG=260539 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247234

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -4 lines) Patch
M chrome/browser/chromeos/drive/change_list_loader.h View 4 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader.cc View 7 chunks +40 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/change_list_loader_unittest.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
6 years, 11 months ago (2014-01-27 08:56:00 UTC) #1
kinaba
lgtm
6 years, 11 months ago (2014-01-27 09:09:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/132903008/30001
6 years, 11 months ago (2014-01-27 10:53:10 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-27 15:03:06 UTC) #4
Message was sent while issue was closed.
Change committed as 247234

Powered by Google App Engine
This is Rietveld 408576698