Issue 132903008: drive: Implement lock mechanism to ChangeListLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 132903008: drive: Implement lock mechanism to ChangeListLoader (Closed)

Created:
6 years, 11 months ago by hashimoto

Modified:
6 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Implement lock mechanism to ChangeListLoader ChangeListLoader should be locked while EntryUpdatePerformer is creating a new entry on the server. Otherwise, it may recieve a change list which contains the new entry and confuse the sync mechanism. BUG=260539 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247234

Patch Set 1 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -4 lines)			Patch
M	chrome/browser/chromeos/drive/change_list_loader.h	View	4 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_loader.cc	View	7 chunks	+40 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/change_list_loader_unittest.cc	View	2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/132903008/30001

6 years, 11 months ago (2014-01-27 10:53:10 UTC) #3

Message was sent while issue was closed.

Change committed as 247234

Expand Messages | Collapse Messages