Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 132903007: Minor refactoring to avoid redundant calls to VisibleSelection::visibleStart() (Closed)

Created:
6 years, 11 months ago by vanihegde
Modified:
6 years, 11 months ago
CC:
blink-reviews, vani
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Minor refactoring to avoid redundant calls to VisibleSelection::visibleStart() We can avoid redundant calls to visibleStart() which indirectly calls several functions like canonicalPosition, isCandidate, upstream, downstream, etc. by using a local variable. Current code already makes use of a local variable to store the VisiblePosition returned by visibleStart(). Just preponing the creation of this local variable would avoid few more redundant calls. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/editing/TypingCommand.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vanihegde
Minor change. Please take a look. Thanks!
6 years, 11 months ago (2014-01-22 09:52:16 UTC) #1
leviw_travelin_and_unemployed
lgtm Okay.
6 years, 11 months ago (2014-01-22 21:28:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/132903007/1
6 years, 11 months ago (2014-01-22 21:29:21 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 22:52:11 UTC) #4
Message was sent while issue was closed.
Change committed as 165561

Powered by Google App Engine
This is Rietveld 408576698