Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 132903005: Fix nan definition on GN Android build. (Closed)

Created:
6 years, 11 months ago by brettw
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Fix nan definition on GN Android build. This resulted in a double -D definition. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244203

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 11 months ago (2014-01-10 17:56:42 UTC) #1
brettw
Committed patchset #1 manually as r244203 (presubmit successful).
6 years, 11 months ago (2014-01-10 18:17:12 UTC) #2
scottmg
6 years, 11 months ago (2014-01-10 19:50:29 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698