Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Issue 1328963004: Revert of [builtins] Unify the various versions of [[Call]] with a Call builtin. (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
CC:
v8-dev, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Unify the various versions of [[Call]] with a Call builtin. (patchset #10 id:260001 of https://codereview.chromium.org/1311013008/ ) Reason for revert: Breaks nosnap, needs investigation Original issue's description: > [builtins] Unify the various versions of [[Call]] with a Call builtin. > > The new Call and CallFunction builtins supersede the current > CallFunctionStub (and CallIC magic) and will be the single bottleneck > for all calling, including the currently special Function.prototype.call > and Function.prototype.apply builtins, which had handwritten (and > not fully compliant) versions of CallFunctionStub, and also the > CallIC(s), which where also slightly different. > > This also reduces the overhead for API function calls, which is still > unnecessary high, but let's do that step-by-step. > > This also fixes a bunch of cases where the implicit ToObject for > sloppy receivers was done in the wrong context (in the caller > context instead of the callee context), which basically meant > that we allowed cross context access to %ObjectPrototype%. > > MIPS and MIPS64 ports contributed by akos.palfi@imgtec.com. > > R=mstarzinger@chromium.org, jarin@chromium.org, mvstanton@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg > BUG=v8:4413 > LOG=n > > Committed: https://crrev.com/ef268a83be4dead004047c25b702319ea4be7277 > Cr-Commit-Position: refs/heads/master@{#30627} TBR=rmcilroy@chromium.org,jarin@chromium.org,mstarzinger@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4413 Committed: https://crrev.com/298d4a6b7636f9c8aace971e8fe35500fbd40392 Cr-Commit-Position: refs/heads/master@{#30628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1632 lines, -1354 lines) Patch
M src/arm/builtins-arm.cc View 5 chunks +235 lines, -158 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 7 chunks +38 lines, -11 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 3 chunks +1 line, -23 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 5 chunks +224 lines, -154 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 7 chunks +39 lines, -11 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/contexts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 4 chunks +218 lines, -178 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 7 chunks +41 lines, -11 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 5 chunks +0 lines, -38 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M src/mips/builtins-mips.cc View 5 chunks +230 lines, -163 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +37 lines, -11 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 3 chunks +0 lines, -24 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 5 chunks +230 lines, -161 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 7 chunks +38 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 3 chunks +0 lines, -24 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.js View 5 chunks +29 lines, -16 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/x64/builtins-x64.cc View 4 chunks +210 lines, -168 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 7 chunks +55 lines, -24 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +0 lines, -21 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of [builtins] Unify the various versions of [[Call]] with a Call builtin.
5 years, 3 months ago (2015-09-08 06:11:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328963004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328963004/1
5 years, 3 months ago (2015-09-08 06:12:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 06:12:28 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 06:12:56 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/298d4a6b7636f9c8aace971e8fe35500fbd40392
Cr-Commit-Position: refs/heads/master@{#30628}

Powered by Google App Engine
This is Rietveld 408576698