Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1328963003: setValueCurve can start at the end of other automations (Closed)

Created:
5 years, 3 months ago by Raymond Toy
Modified:
5 years, 3 months ago
Reviewers:
hochchan, hongchan
CC:
Raymond Toy, blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

setValueCurve can start at the end of other automations It is valid to do this: linearRampToValueAtTime(0, 1); setValueCurveAtTime(curve, 1, 1); Previously, this caused an error because the code thought the two methods overlapped. BUG=528423 TEST=audioparam-setValueCurve-exceptions.html updated with more tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M LayoutTests/webaudio/audioparam-setValueCurve-exceptions.html View 1 chunk +66 lines, -0 lines 0 comments Download
M LayoutTests/webaudio/audioparam-setValueCurve-exceptions-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/modules/webaudio/AudioParamTimeline.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Raymond Toy
PTAL.
5 years, 3 months ago (2015-09-04 21:23:30 UTC) #2
hongchan
lgtm
5 years, 3 months ago (2015-09-04 22:45:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328963003/1
5 years, 3 months ago (2015-09-04 22:49:06 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 23:27:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201832

Powered by Google App Engine
This is Rietveld 408576698