Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1328963002: Build shared_memory_mac.cc and shared_memory_handle_mac.cc for iOS (Closed)

Created:
5 years, 3 months ago by jfroy
Modified:
5 years, 3 months ago
CC:
chromium-reviews, gavinp+memory_chromium.org, lite
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build shared_memory_mac.cc and shared_memory_handle_mac.cc for iOS media::VideoFrame has new constructors that use SharedMemory and SharedMemoryHandle. This patch enables building the Mac implementations to support building //media/cast/sender on iOS. BUG=528408 Committed: https://crrev.com/cc7516ec9d89cff1d5cfe72794395c1a1c95908e Cr-Commit-Position: refs/heads/master@{#347569}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M base/memory/BUILD.gn View 1 chunk +9 lines, -0 lines 0 comments Download
M base/memory/shared_memory_handle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
jfroy
5 years, 3 months ago (2015-09-04 19:41:04 UTC) #2
jfroy
5 years, 3 months ago (2015-09-04 19:41:59 UTC) #4
jfroy
5 years, 3 months ago (2015-09-04 19:44:29 UTC) #6
miu
lgtm
5 years, 3 months ago (2015-09-04 20:15:07 UTC) #7
Mark Mentovai
LGTM
5 years, 3 months ago (2015-09-04 20:28:25 UTC) #8
DaleCurtis
not an owner for this, but lgtm :)
5 years, 3 months ago (2015-09-04 22:26:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328963002/1
5 years, 3 months ago (2015-09-04 22:48:47 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/103656)
5 years, 3 months ago (2015-09-05 00:11:25 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328963002/1
5 years, 3 months ago (2015-09-05 06:57:39 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-05 08:47:50 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 08:48:33 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc7516ec9d89cff1d5cfe72794395c1a1c95908e
Cr-Commit-Position: refs/heads/master@{#347569}

Powered by Google App Engine
This is Rietveld 408576698