Mandoline: Support transforms and clipping of OOPIFs and events

components/mus/connection_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/mus/connection_manager.h"
 
 #include "base/logging.h"
 #include "base/stl_util.h"
 #include "cc/output/compositor_frame.h"
 #include "cc/quads/shared_quad_state.h"
+#include "cc/quads/surface_draw_quad.h"
 #include "components/mus/client_connection.h"
 #include "components/mus/connection_manager_delegate.h"
 #include "components/mus/server_view.h"
 #include "components/mus/view_coordinate_conversions.h"
 #include "components/mus/view_tree_host_connection.h"
 #include "components/mus/view_tree_impl.h"
 #include "mojo/application/public/cpp/application_connection.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/converters/input_events/input_events_type_converters.h"
 #include "mojo/converters/surfaces/surfaces_type_converters.h"
@@ skipping 417 matching lines @@
   unsigned int id = static_cast<unsigned int>(
       input->surface_quad_state->surface.To<cc::SurfaceId>().id);
   // TODO(fsamuel): Security checks:
   // 1. We need to make sure the embedder can only position views it's allowed
   //    to access.
   // 2. We need to make sure that the embedder cannot place views in areas
   //    outside of its own bounds.
   ServerView* view = GetView(ViewIdFromTransportId(id));
   // If a CompositorFrame message arrives late, say during a navigation, then
   // it may contain view IDs that no longer exist.
-  if (!view)
+  if (!view || view->surface_id().is_null())
     return false;
-  gfx::Rect bounds(input->visible_rect.To<gfx::Rect>());
-  gfx::Point p;
-  sqs->quad_to_target_transform.TransformPoint(&p);
-  bounds.set_origin(p);
-  // TODO(fsamuel): This seems like a crude way to set the size that probably
-  // doesn't work correctly in the general case. We need to get transforms
-  // working correctly in the general case.
-  bounds.set_size(gfx::ToRoundedSize(
-      gfx::ScaleSize(bounds.size(), metadata->device_scale_factor)));
-  view->SetBounds(bounds);
+
+  cc::SurfaceDrawQuad* surface_quad =
+      render_pass->CreateAndAppendDrawQuad<cc::SurfaceDrawQuad>();

[rjkroege, 2015/09/16 21:31:37]

where do we validate the contents of the provided CompositorFrame for malicious
payload? please put a TODO there.

why is connection_mangement doing graphics work? this seems like a failure to
separate concerns (more TODOs probably)

do you have a block-diagram of mus? I've seen fragments of one. Can you put one
together that's more detailed?

[Fady Samuel, 2015/09/17 18:31:42]

There's a TODO above.

Added a todo and filed a bug for moving this out of connectionmanager.

I'll write a block diagram for mus. I've added a doc to your phase 1 doc with a
partial diagram.

+  surface_quad->SetAll(
+      sqs,
+      input->rect.To<gfx::Rect>(),
+      input->opaque_rect.To<gfx::Rect>(),
+      input->visible_rect.To<gfx::Rect>(),
+      input->needs_blending,
+      view->surface_id());
   return true;
 }
 
 }  // namespace view_manager