Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 132893002: Add OWNERS for the top-level BUILD.gn file. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add OWNERS for the top-level BUILD.gn file. Otherwise CQ will complain with: ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: BUILD.gn R=brettw@chromium.org, darin@chromium.org TBR=darin NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244049

Patch Set 1 #

Patch Set 2 : add for .gn as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 11 months ago (2014-01-09 23:58:06 UTC) #1
brettw
Good idea. Can you also add one for the ".gn" file in that directory? LGTM
6 years, 11 months ago (2014-01-10 00:02:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/132893002/50001
6 years, 11 months ago (2014-01-10 01:25:25 UTC) #3
tfarina
Committed patchset #2 manually as r244049 (presubmit successful).
6 years, 11 months ago (2014-01-10 02:33:31 UTC) #4
darin (slow to review)
6 years, 11 months ago (2014-01-10 05:31:15 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698