Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: Source/core/layout/LayoutFlowThread.h

Issue 1328923002: Avoid stack overflow triggered by out-of-band layout of flexbox child. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update test. The previous one started to pass, because of https://codereview.chromium.org/129593300… Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/LayoutBlockFlow.cpp ('k') | Source/core/layout/LayoutMultiColumnFlowThread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutFlowThread.h
diff --git a/Source/core/layout/LayoutFlowThread.h b/Source/core/layout/LayoutFlowThread.h
index 2a8a546633cefeaa687fe5c4180fe6494a4fc057..2aa7ca0c989e71707e40ffb4ec1ea4c80773b7d4 100644
--- a/Source/core/layout/LayoutFlowThread.h
+++ b/Source/core/layout/LayoutFlowThread.h
@@ -64,11 +64,6 @@ public:
// can easily avoid drawing the children directly.
DeprecatedPaintLayerType layerTypeRequired() const final { return NormalDeprecatedPaintLayer; }
- // Skip past a column spanner during flow thread layout. Spanners are not laid out inside the
- // flow thread, since the flow thread is not in a spanner's containing block chain (since the
- // containing block is the multicol container).
- virtual void skipColumnSpanner(LayoutBox*, LayoutUnit logicalTopInFlowThread) { }
-
virtual void flowThreadDescendantWasInserted(LayoutObject*) { }
virtual void flowThreadDescendantWillBeRemoved(LayoutObject*) { }
virtual void flowThreadDescendantStyleWillChange(LayoutObject*, StyleDifference, const ComputedStyle& newStyle) { }
« no previous file with comments | « Source/core/layout/LayoutBlockFlow.cpp ('k') | Source/core/layout/LayoutMultiColumnFlowThread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698