Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1328883002: move gconf config inside use_gconf block (Closed)

Created:
5 years, 3 months ago by Mostyn Bramley-Moore
Modified:
5 years, 3 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

move gconf config inside use_gconf block BUG=132847 Committed: https://crrev.com/b30be3c8b06b05a79f8602fc93e0944bfb07e319 Cr-Commit-Position: refs/heads/master@{#347440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/libgtk2ui/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Mostyn Bramley-Moore
@Elliot: please take a look at this small fixup to https://codereview.chromium.org/1293073006
5 years, 3 months ago (2015-09-04 08:33:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328883002/1
5 years, 3 months ago (2015-09-04 08:50:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 09:32:00 UTC) #6
Elliot Glaysher
lgtm
5 years, 3 months ago (2015-09-04 17:03:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328883002/1
5 years, 3 months ago (2015-09-04 17:21:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 17:26:52 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 17:27:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b30be3c8b06b05a79f8602fc93e0944bfb07e319
Cr-Commit-Position: refs/heads/master@{#347440}

Powered by Google App Engine
This is Rietveld 408576698