Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.h

Issue 1328873002: Limit overlap between BubbleManager and BaseBubbleController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bm-add-update.gitbr
Patch Set: Rename method to closeBubble Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/base_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.h b/chrome/browser/ui/cocoa/base_bubble_controller.h
index 8bff2255bd9d4e4c90bc8128e8e78ced584f54e9..b4d8bd010ea7f9317f66d82fb38af2593a5bd6ac 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/base_bubble_controller.h
@@ -5,6 +5,7 @@
#import <Cocoa/Cocoa.h>
#include "base/memory/scoped_ptr.h"
+#include "components/bubble/bubble_reference.h"
@class InfoBubbleView;
class TabStripModelObserverBridge;
@@ -45,6 +46,7 @@ class TabStripModelObserverBridge;
BOOL shouldOpenAsKeyWindow_;
// The bubble window should close if it (or its parent) resigns key status.
BOOL shouldCloseOnResignKey_;
+ BubbleReference bubbleReference_;
}
@property(nonatomic, assign) NSWindow* parentWindow;
@@ -55,6 +57,8 @@ class TabStripModelObserverBridge;
@property(nonatomic, assign) BOOL shouldOpenAsKeyWindow;
// Controls if the bubble auto-closes if the user clicks outside the bubble.
@property(nonatomic, assign) BOOL shouldCloseOnResignKey;
+// A reference for bubbles that are managed by the BubbleManager.
+@property(nonatomic, assign) BubbleReference bubbleReference;
// Creates a bubble. |nibPath| is just the basename, e.g. @"FirstRunBubble".
// |anchoredAt| is in screen space. You need to call -showWindow: to make the
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698