DevTools: introduce WI.SourceMap.Entry structure and cleanup WI.SourceMap API.

Source/devtools/front_end/bindings/CompilerScriptMapping.js

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 79 matching lines @@
         var stubUISourceCode = this._stubUISourceCodes.get(debuggerModelLocation.scriptId);
         if (stubUISourceCode)
             return new WebInspector.UILocation(stubUISourceCode, rawLocation.lineNumber, rawLocation.columnNumber);
 
         var sourceMap = this._sourceMapForScriptId[debuggerModelLocation.scriptId];
         if (!sourceMap)
             return null;
         var lineNumber = debuggerModelLocation.lineNumber;
         var columnNumber = debuggerModelLocation.columnNumber || 0;
         var entry = sourceMap.findEntry(lineNumber, columnNumber);
-        if (!entry || entry.length === 2)
+        if (!entry || !entry.sourceURL)
             return null;
-        var url = /** @type {string} */ (entry[2]);
-        var uiSourceCode = this._networkMapping.uiSourceCodeForURL(url, this._target);
+        var uiSourceCode = this._networkMapping.uiSourceCodeForURL(/** @type {string} */ (entry.sourceURL), this._target);
         if (!uiSourceCode)
             return null;
-        return uiSourceCode.uiLocation(/** @type {number} */ (entry[3]), /** @type {number} */ (entry[4]));
+        return uiSourceCode.uiLocation(/** @type {number} */ (entry.sourceLineNumber), /** @type {number} */ (entry.sourceColumnNumber));
     },
 
     /**
      * @override
      * @param {!WebInspector.UISourceCode} uiSourceCode
      * @param {number} lineNumber
      * @param {number} columnNumber
      * @return {?WebInspector.DebuggerModel.Location}
      */
     uiLocationToRawLocation: function(uiSourceCode, lineNumber, columnNumber)
     {
         if (uiSourceCode.project().type() === WebInspector.projectTypes.Service)
             return null;
         var networkURL = this._networkMapping.networkURL(uiSourceCode);
         if (!networkURL)
             return null;
         var sourceMap = this._sourceMapForURL.get(networkURL);
         if (!sourceMap)
             return null;
         var script = /** @type {!WebInspector.Script} */ (this._scriptForSourceMap.get(sourceMap));
         console.assert(script);
+        var entry = null;
         var mappingSearchLinesCount = 5;

[pfeldman, 2015/09/04 01:38:36]

Lets remove this.

[lushnikov, 2015/09/04 17:46:45]

Done.

-        // We do not require precise (breakpoint) location but limit the number of lines to search or mapping.
-        var entry = sourceMap.findEntryReversed(networkURL, lineNumber, mappingSearchLinesCount);
+        for (var i = 0; i < mappingSearchLinesCount && !entry; ++i)
+            entry = sourceMap.firstSourceLineMapping(networkURL, lineNumber + i);
         if (!entry)
             return null;
-        return this._debuggerModel.createRawLocation(script, /** @type {number} */ (entry[0]), /** @type {number} */ (entry[1]));
+        return this._debuggerModel.createRawLocation(script, entry.lineNumber, entry.columnNumber);
     },
 
     /**
      * @param {!WebInspector.Script} script
      */
     addScript: function(script)
     {
         if (!script.sourceMapURL) {
             script.addEventListener(WebInspector.Script.Events.SourceMapURLAdded, this._sourceMapURLAdded.bind(this));
             return;
@@ skipping 101 matching lines @@
      * @return {boolean}
      */
     uiLineHasMapping: function(uiSourceCode, lineNumber)
     {
         var networkURL = this._networkMapping.networkURL(uiSourceCode);
         if (!networkURL)
             return true;
         var sourceMap = this._sourceMapForURL.get(networkURL);
         if (!sourceMap)
             return true;
-        return !!sourceMap.findEntryReversed(networkURL, lineNumber, 0);
+        return !!sourceMap.firstSourceLineMapping(networkURL, lineNumber);
     },
 
     /**
      * @param {!WebInspector.UISourceCode} uiSourceCode
      */
     _bindUISourceCode: function(uiSourceCode)
     {
         this._debuggerWorkspaceBinding.setSourceMapping(this._target, uiSourceCode, this);
     },
 
@@ skipping 96 matching lines @@
         this._sourceMapForScriptId = {};
         this._scriptForSourceMap.clear();
         this._sourceMapForURL.clear();
     },
 
     dispose: function()
     {
         this._workspace.removeEventListener(WebInspector.Workspace.Events.UISourceCodeAdded, this._uiSourceCodeAddedToWorkspace, this);
     }
 }