Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1328843002: DevTools: introduce WI.SourceMap.Entry structure and cleanup WI.SourceMap API. (Closed)

Created:
5 years, 3 months ago by lushnikov
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: introduce WI.SourceMap.Entry structure and cleanup WI.SourceMap API. The patch: - Use WI.SourceMap.Entry instead of an array tuples. - Establish correct reversed mappings BUG=527993, 463023 R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201848

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 4

Patch Set 3 : fix comment #

Patch Set 4 : fix test #

Messages

Total messages: 12 (5 generated)
lushnikov
ptal
5 years, 3 months ago (2015-09-03 20:47:30 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1328843002/diff/20001/Source/devtools/front_end/bindings/CompilerScriptMapping.js File Source/devtools/front_end/bindings/CompilerScriptMapping.js (right): https://codereview.chromium.org/1328843002/diff/20001/Source/devtools/front_end/bindings/CompilerScriptMapping.js#newcode128 Source/devtools/front_end/bindings/CompilerScriptMapping.js:128: var mappingSearchLinesCount = 5; Lets remove this. https://codereview.chromium.org/1328843002/diff/20001/Source/devtools/front_end/sdk/SourceMap.js ...
5 years, 3 months ago (2015-09-04 01:38:36 UTC) #2
lushnikov
https://codereview.chromium.org/1328843002/diff/20001/Source/devtools/front_end/bindings/CompilerScriptMapping.js File Source/devtools/front_end/bindings/CompilerScriptMapping.js (right): https://codereview.chromium.org/1328843002/diff/20001/Source/devtools/front_end/bindings/CompilerScriptMapping.js#newcode128 Source/devtools/front_end/bindings/CompilerScriptMapping.js:128: var mappingSearchLinesCount = 5; On 2015/09/04 01:38:36, pfeldman wrote: ...
5 years, 3 months ago (2015-09-04 17:46:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328843002/40001
5 years, 3 months ago (2015-09-04 17:47:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/103467)
5 years, 3 months ago (2015-09-04 18:58:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328843002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328843002/60001
5 years, 3 months ago (2015-09-05 23:59:40 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-06 02:24:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201848

Powered by Google App Engine
This is Rietveld 408576698