Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 132883007: Revert of Fetch Windows tools on Cygwin and use that Python for some scripts (Closed)

Created:
6 years, 11 months ago by Reid Kleckner
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Revert of Fetch Windows tools on Cygwin and use that Python for some scripts (https://codereview.chromium.org/140843004/) Reason for revert: This broke auto-updating depot_tools on Cygwin due to use of exec Original issue's description: > Fetch Windows tools on Cygwin and use that Python for some scripts > > Tested by running gclient sync a couple of times from a Cygwin shell. > > R=dpranke@chromium.org > CC=scottmg@chromium.org,thakis@chromium.org,maruel@chromium.org > BUG=335180 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245315 TBR=dpranke@chromium.org NOTREECHECKS=true NOTRY=true BUG=335180 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -25 lines) Patch
M fetch View 1 chunk +1 line, -9 lines 0 comments Download
M gclient View 1 chunk +1 line, -9 lines 0 comments Download
M update_depot_tools View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Reid Kleckner
Created Revert of Fetch Windows tools on Cygwin and use that Python for some scripts
6 years, 11 months ago (2014-01-16 21:32:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@chromium.org/132883007/1
6 years, 11 months ago (2014-01-16 21:32:39 UTC) #2
commit-bot: I haz the power
Change committed as 245330
6 years, 11 months ago (2014-01-16 21:35:03 UTC) #3
Dirk Pranke
On 2014/01/16 21:35:03, I haz the power (commit-bot) wrote: > Change committed as 245330 Hm. ...
6 years, 11 months ago (2014-01-16 21:44:46 UTC) #4
Reid Kleckner (google)
6 years, 11 months ago (2014-01-16 21:50:04 UTC) #5
On Thu, Jan 16, 2014 at 1:44 PM, <dpranke@chromium.org> wrote:

> On 2014/01/16 21:35:03, I haz the power (commit-bot) wrote:
>
>> Change committed as 245330
>>
>
> Hm. Whoops :). LGTM.
>

Scott Violet also reported breakage on IRC.  gclient attempted to invoke
depot_tools/python.bat, and it didn't exist, meaning fetching failed
somehow.

I don't have time to really dig into these issues at the moment. =/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698