Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1316)

Unified Diff: Source/core/layout/LayoutText.cpp

Issue 1328803003: Remove GlyphOverflow.computeBounds as it's no longer used for -webkit-line-box-contain. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/layout/line/GlyphOverflow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutText.cpp
diff --git a/Source/core/layout/LayoutText.cpp b/Source/core/layout/LayoutText.cpp
index ed1bb2720d05c38384c5fa95b1b3ac162f787d5b..173f6e38383864d60c045507b7850c1b804340e4 100644
--- a/Source/core/layout/LayoutText.cpp
+++ b/Source/core/layout/LayoutText.cpp
@@ -1111,8 +1111,6 @@ void LayoutText::computePreferredLogicalWidths(float leadWidth, HashSet<const Si
m_lastLineLineMinWidth = currMaxWidth;
}
- // TODO(wkorman): Look into potentially removing GlyphOverflow or at least the
- // computeBounds field as we no longer use it for line-box-contain implementation.
GlyphOverflow glyphOverflow;
glyphOverflow.setFromBounds(glyphBounds, f.fontMetrics().floatAscent(), f.fontMetrics().floatDescent(), m_maxWidth);
// We shouldn't change our mind once we "know".
« no previous file with comments | « no previous file | Source/core/layout/line/GlyphOverflow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698