Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328803003: Remove GlyphOverflow.computeBounds as it's no longer used for -webkit-line-box-contain. (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
Xianzhu, eae
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove GlyphOverflow.computeBounds as it's no longer used for -webkit-line-box-contain. BUG=522215 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201742

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M Source/core/layout/LayoutText.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/line/GlyphOverflow.h View 3 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
wkorman
It looks like we're still using GlyphOverflow perhaps for other caching/computation purposes per some changes ...
5 years, 3 months ago (2015-09-03 18:18:15 UTC) #2
eae
LGTM This is great and will allow us to cache the resulting bounds rather than ...
5 years, 3 months ago (2015-09-03 18:37:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328803003/1
5 years, 3 months ago (2015-09-03 20:25:17 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 21:28:43 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201742

Powered by Google App Engine
This is Rietveld 408576698