Issue 13288002: Revert 190475 "Merge 189983 "Add speaker on/off control on Andro..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13288002: Revert 190475 "Merge 189983 "Add speaker on/off control on Andro..." (Closed)

Created:
7 years, 8 months ago by wjia(left Chromium)

Modified:
7 years, 8 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

Revert 190475 "Merge 189983 "Add speaker on/off control on Andro..." It needs bluetooth permission on some devices. > Merge 189983 "Add speaker on/off control on Android for WebRTC " > > > Add speaker on/off control on Android for WebRTC > > > > Application listens to the headset plug intent, turns on or off speaker when > > webrtc is running. It will help devices with dual mics to improve audio > > quality. > > > > BUG=222394 > > Contributed by leozwang@chromium.org (https://chromiumcodereview.appspot.com/12974004/) > > > > reland https://src.chromium.org/viewvc/chrome?view=rev&revision=189870 with unit tests fixed. > > Review URL: https://codereview.chromium.org/12911007 > > TBR=wjia@chromium.org > Review URL: https://codereview.chromium.org/13006011 TBR=wjia@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191283

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -156 lines)			Patch
M	content/browser/renderer_host/media/audio_input_device_manager_unittest.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	content/test/webrtc_audio_device_test.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	media/audio/audio_input_controller_unittest.cc	View	6 chunks	+30 lines, -16 lines	0 comments	Download
M	media/audio/audio_input_device_unittest.cc	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	media/audio/audio_input_unittest.cc	View	6 chunks	+26 lines, -14 lines	0 comments	Download
M	media/audio/audio_manager_base.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	media/audio/audio_manager_base.cc	View	5 chunks	+10 lines, -36 lines	0 comments	Download
M	media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java	View	2 chunks	+5 lines, -50 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r191283.