Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1328783002: [turbofan] Greedy: split around calls heuristic. (Closed)

Created:
5 years, 3 months ago by Mircea Trofin
Modified:
5 years, 3 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev, Jim Stichnoth, jvoung (off chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Greedy: split around calls heuristic. Once a range is found to have a conflict, split around all the calls it crosses over, since it will anyway have conflicts there, too. Incrementally, from the last change to greedy, this change brings overall improvement in benchmarks. In fact, except for 2 regressions in Jetstream (splay-latency and date-format-xparb, at 6 and 7% respectivelly), everything else is in the green or noise. Quite a few benchmarks are over 3%, with a few (zlib, for example) in the double digits. Committed: https://crrev.com/db646fb2f88cb30042a8bc79281e129f4ce36de0 Cr-Commit-Position: refs/heads/master@{#30579}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -7 lines) Patch
M src/compiler/greedy-allocator.h View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/compiler/greedy-allocator.cc View 1 2 1 chunk +87 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mircea Trofin
5 years, 3 months ago (2015-09-04 05:59:27 UTC) #2
Jarin
lgtm
5 years, 3 months ago (2015-09-04 06:47:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328783002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328783002/40001
5 years, 3 months ago (2015-09-04 06:48:12 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-04 06:50:23 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 06:50:39 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/db646fb2f88cb30042a8bc79281e129f4ce36de0
Cr-Commit-Position: refs/heads/master@{#30579}

Powered by Google App Engine
This is Rietveld 408576698