Source/core/layout/line/InlineFlowBox.cpp - Issue 1328723002: [Line Layout API] Add border*() to LineLayoutBoxModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/line/InlineFlowBox.cpp

Issue 1328723002: [Line Layout API] Add border*() to LineLayoutBoxModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/line/InlineFlowBox.cpp

diff --git a/Source/core/layout/line/InlineFlowBox.cpp b/Source/core/layout/line/InlineFlowBox.cpp

index 70d3a7b3f9445f408393aa06dc2fc2b6264d520f..98a1204a254c87cf06e2a0d247709502835a4d49 100644

--- a/Source/core/layout/line/InlineFlowBox.cpp

+++ b/Source/core/layout/line/InlineFlowBox.cpp

@@ -624,7 +624,7 @@ void InlineFlowBox::placeBoxesInBlockDirection(LayoutUnit top, LayoutUnit maxHei

const FontMetrics& fontMetrics = curr->layoutObject().style(isFirstLineStyle())->fontMetrics();

newLogicalTop += curr->baselinePosition(baselineType) - fontMetrics.ascent(baselineType);

if (curr->isInlineFlowBox()) {

- LayoutBoxModelObject& boxObject = toLayoutBoxModelObject(curr->layoutObject());

+ LineLayoutBoxModel boxObject = LineLayoutBoxModel(curr->lineLayoutItem());

newLogicalTop -= boxObject.style(isFirstLineStyle())->isHorizontalWritingMode() ? boxObject.borderTop() + boxObject.paddingTop() :

boxObject.borderRight() + boxObject.paddingRight();

borderPaddingHeight = boxObject.borderAndPaddingLogicalHeight();