Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328723002: [Line Layout API] Add border*() to LineLayoutBoxModel (Closed)

Created:
5 years, 3 months ago by pilgrim_google
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Line Layout API] Add border*() to LineLayoutBoxModel This CL updates callers in InlineFlowBox. BUG=499321 Committed: https://crrev.com/157fbe18bf0b86ff74b45278aae9b6b676d4e9d1 git-svn-id: svn://svn.chromium.org/blink/trunk@202005 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 1

Patch Set 2 : add borderBottom for completeness #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M Source/core/layout/api/LineLayoutBoxModel.h View 1 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
pilgrim_google
5 years, 3 months ago (2015-09-02 20:11:48 UTC) #2
eae
https://codereview.chromium.org/1328723002/diff/1/Source/core/layout/api/LineLayoutBoxModel.h File Source/core/layout/api/LineLayoutBoxModel.h (right): https://codereview.chromium.org/1328723002/diff/1/Source/core/layout/api/LineLayoutBoxModel.h#newcode125 Source/core/layout/api/LineLayoutBoxModel.h:125: What about borderBottom?
5 years, 3 months ago (2015-09-02 20:32:57 UTC) #3
pilgrim_google
5 years, 3 months ago (2015-09-03 15:38:02 UTC) #4
pilgrim_google
bump
5 years, 3 months ago (2015-09-08 14:12:00 UTC) #5
eae
LGTM, thanks and sorry about the delay
5 years, 3 months ago (2015-09-09 16:57:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328723002/40001
5 years, 3 months ago (2015-09-09 17:08:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/104806)
5 years, 3 months ago (2015-09-09 18:08:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328723002/40001
5 years, 3 months ago (2015-09-09 20:48:52 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202005
5 years, 3 months ago (2015-09-09 21:57:12 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:04:02 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/157fbe18bf0b86ff74b45278aae9b6b676d4e9d1

Powered by Google App Engine
This is Rietveld 408576698