Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1328673003: Remove -webkit-line-box-contain implementation. (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh, eae
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-rendering, blink-reviews-style_chromium.org, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove -webkit-line-box-contain implementation. Currently absent from specifications and seeing very low usage. We can restore this functionality in the future un-prefixed if/when it's clarified in a spec. Usage: 0.0221% Intent To Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/rKDXtqvgDv4/1Q5ByQllDAAJ BUG=522215 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201690

Patch Set 1 #

Patch Set 2 : Merge changes. #

Patch Set 3 : Remove unused glyphOverflow variable. #

Patch Set 4 : Fix up a few more tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3033 lines) Patch
M LayoutTests/TestExpectations View 1 3 chunks +1 line, -3 lines 0 comments Download
D LayoutTests/fast/block/float/floats-offset-linebox-contain-block.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/block/float/floats-offset-linebox-contain-block-expected.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/block/float/floats-offset-linebox-contain-inline.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/block/float/floats-offset-linebox-contain-inline-expected.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/block.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/block-font.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/block-glyphs.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/block-glyphs-replaced.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/block-replaced.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/block-with-ideographs.xhtml View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/font.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/font-replaced.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/glyphs.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/glyphs-clipping.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/inline.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/inline-box.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/inline-box-replaced.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/inline-box-vertical.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/inline-replaced.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/none.html View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/parsing-invalid.html View 1 chunk +0 lines, -40 lines 0 comments Download
D LayoutTests/fast/block/lineboxcontain/replaced.html View 1 chunk +0 lines, -14 lines 0 comments Download
M LayoutTests/fast/css/first-letter-property-whitelist.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/block-glyphs-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/block-with-ideographs-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/glyphs-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/inline-box-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/inline-box-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/android/fast/block/lineboxcontain/parsing-invalid-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-font-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-replaced-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-with-ideographs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/block-with-ideographs-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/font-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/font-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/font-replaced-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/glyphs-clipping-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/glyphs-clipping-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/glyphs-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-box-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-box-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-box-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-box-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-box-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-box-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/inline-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/none-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/none-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/parsing-invalid-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/block/lineboxcontain/replaced-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-mavericks/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-font-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-glyphs-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-replaced-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/block-with-ideographs-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/font-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/font-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/glyphs-clipping-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/glyphs-clipping-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/glyphs-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/inline-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/none-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/none-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/parsing-invalid-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/block/lineboxcontain/replaced-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-font-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-glyphs-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-glyphs-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-replaced-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-with-ideographs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/block-with-ideographs-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/font-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/font-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/font-replaced-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/glyphs-clipping-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/glyphs-clipping-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/glyphs-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-box-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-box-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-box-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-box-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-box-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-box-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/inline-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/none-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/none-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/parsing-invalid-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/block/lineboxcontain/replaced-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-font-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-glyphs-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-glyphs-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-replaced-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-with-ideographs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/block-with-ideographs-expected.txt View 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/font-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/font-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/font-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/font-replaced-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/glyphs-clipping-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/glyphs-clipping-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/glyphs-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/glyphs-expected.txt View 1 chunk +0 lines, -37 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-box-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-box-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-box-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-box-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-box-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-box-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/inline-replaced-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/none-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/none-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/parsing-invalid-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/parsing-invalid-expected.txt View 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/replaced-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/block/lineboxcontain/replaced-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/svg/css/getComputedStyle-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/css/CSSLineBoxContainValue.h View 1 chunk +0 lines, -63 lines 0 comments Download
D Source/core/css/CSSLineBoxContainValue.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.cpp View 6 chunks +0 lines, -14 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 3 chunks +0 lines, -37 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 4 chunks +1 line, -7 lines 0 comments Download
M Source/core/layout/LayoutText.cpp View 1 chunk +7 lines, -10 lines 0 comments Download
M Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/layout/line/RootInlineBox.cpp View 1 2 4 chunks +7 lines, -95 lines 0 comments Download
M Source/core/style/ComputedStyle.h View 4 chunks +0 lines, -4 lines 0 comments Download
M Source/core/style/ComputedStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/style/StyleRareInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/style/StyleRareInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
wkorman
+timloh to make sure I've not done anything unsavory CSS-wise, and +eae for layout bits.
5 years, 3 months ago (2015-09-02 18:27:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328673003/20001
5 years, 3 months ago (2015-09-02 18:28:10 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/111108) android_chromium_gn_compile_rel on ...
5 years, 3 months ago (2015-09-02 19:00:58 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328673003/40001
5 years, 3 months ago (2015-09-02 19:51:56 UTC) #8
Timothy Loh
On 2015/09/02 18:27:17, wkorman wrote: > +timloh to make sure I've not done anything unsavory ...
5 years, 3 months ago (2015-09-02 20:48:56 UTC) #9
eae
LGTM for layout/
5 years, 3 months ago (2015-09-02 20:51:51 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/102368)
5 years, 3 months ago (2015-09-02 21:06:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328673003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328673003/50001
5 years, 3 months ago (2015-09-03 00:07:39 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 02:30:44 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201690

Powered by Google App Engine
This is Rietveld 408576698