Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1741)

Unified Diff: Source/web/tests/WebUnitTests.cpp

Issue 1328653002: Introduce V8GCController::collectAllGarbage (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebLeakDetector.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebUnitTests.cpp
diff --git a/Source/web/tests/WebUnitTests.cpp b/Source/web/tests/WebUnitTests.cpp
index b8b2cca423988333b95d7f7aa3309fe662c10f06..6b4e2209c021dbd0bf2094b6e97b1df6e8517218 100644
--- a/Source/web/tests/WebUnitTests.cpp
+++ b/Source/web/tests/WebUnitTests.cpp
@@ -31,7 +31,7 @@
#include "config.h"
#include "web/tests/WebUnitTests.h"
-#include "platform/heap/Handle.h"
+#include "bindings/core/v8/V8GCController.h"
#include <base/bind.h>
#include <base/message_loop/message_loop.h>
#include <base/run_loop.h>
@@ -55,8 +55,7 @@ int runHelper(base::TestSuite* testSuite, void (*preTestHook)(void), void (*post
// Collect garbage in order to release mock objects referred from v8 or
// Oilpan heap. Otherwise false mock leaks will be reported.
- v8::Isolate::GetCurrent()->RequestGarbageCollectionForTesting(v8::Isolate::kFullGarbageCollection);
- Heap::collectAllGarbage();
+ V8GCController::collectAllGarbage(v8::Isolate::GetCurrent());
sof 2015/09/02 11:06:08 This might flush out some current unit test "leaks
postTestHook();
« no previous file with comments | « Source/web/WebLeakDetector.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698