Issue 1328593005: Oilpan: Remove unused swap methods for on-heap collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1328593005: Oilpan: Remove unused swap methods for on-heap collections (Closed)

Created:
5 years, 3 months ago by haraken

Modified:
5 years, 3 months ago

Reviewers:
keishi

CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Remove unused swap methods for on-heap collections BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201782

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -15 lines)			Patch
	M	Source/platform/heap/HeapAllocator.h	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

haraken

PTAL. I don't know why these swap methods were needed. Let's see if tests pass.

5 years, 3 months ago (2015-09-04 06:00:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328593005/1

5 years, 3 months ago (2015-09-04 07:10:24 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-04 07:49:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201782

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages