Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2583)

Issue 1328583002: Make the package strong-mode clean. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_span@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the package strong-mode clean. This caught a bug in which we were calling _FileSpan._start and _FileSpan._end on a span we couldn't guarantee to be a _FileSpan. R=sigmund@google.com Committed: https://github.com/dart-lang/source_span/commit/701a5cebffb8970e8cfcec15f244a573a333065c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/file.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 11 months ago (2015-09-01 21:56:36 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2015-09-01 22:22:54 UTC) #3
nweiz
4 years, 11 months ago (2015-09-01 22:45:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
701a5cebffb8970e8cfcec15f244a573a333065c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698