Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1328563003: Fix mojo_runner_unittests in debug builds. (Closed)

Created:
5 years, 3 months ago by jam
Modified:
5 years, 3 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mojo_runner_unittests in debug builds. BUG=527205 Committed: https://crrev.com/1eb5fc26f689f851ea1bc9558dee4073010caf6b Cr-Commit-Position: refs/heads/master@{#346762}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M mojo/runner/about_fetcher_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/runner/shell_test_main.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jam
5 years, 3 months ago (2015-09-01 22:19:26 UTC) #2
yzshen1
LGTM. Thanks! https://codereview.chromium.org/1328563003/diff/1/mojo/runner/shell_test_main.cc File mojo/runner/shell_test_main.cc (right): https://codereview.chromium.org/1328563003/diff/1/mojo/runner/shell_test_main.cc#newcode14 mojo/runner/shell_test_main.cc:14: #include "third_party/mojo/src/mojo/edk/embedder/test_embedder.h" nit: this line is not ...
5 years, 3 months ago (2015-09-01 22:20:42 UTC) #3
jam
https://codereview.chromium.org/1328563003/diff/1/mojo/runner/shell_test_main.cc File mojo/runner/shell_test_main.cc (right): https://codereview.chromium.org/1328563003/diff/1/mojo/runner/shell_test_main.cc#newcode14 mojo/runner/shell_test_main.cc:14: #include "third_party/mojo/src/mojo/edk/embedder/test_embedder.h" On 2015/09/01 22:20:42, yzshen1 wrote: > nit: ...
5 years, 3 months ago (2015-09-01 22:26:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328563003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328563003/20001
5 years, 3 months ago (2015-09-01 22:26:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 22:47:11 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 22:47:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1eb5fc26f689f851ea1bc9558dee4073010caf6b
Cr-Commit-Position: refs/heads/master@{#346762}

Powered by Google App Engine
This is Rietveld 408576698