Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1328563002: clang_tidy net/spdy (Closed)

Created:
5 years, 3 months ago by Bence
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang_tidy net/spdy This CL lands server change 101626129 by assar. BUG=488484 Committed: https://crrev.com/bc634f62cd094d3df5523d4fdd1649038a7e2635 Cr-Commit-Position: refs/heads/master@{#346889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M net/spdy/spdy_frame_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_framer.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_pinnable_buffer_piece.h View 1 chunk +1 line, -3 lines 0 comments Download
M net/spdy/spdy_prefixed_buffer_reader.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/spdy/spdy_test_utils.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/write_blocked_list.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 3 months ago (2015-09-01 21:51:16 UTC) #2
Ryan Hamilton
lgtm
5 years, 3 months ago (2015-09-02 04:16:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328563002/1
5 years, 3 months ago (2015-09-02 11:17:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-02 11:48:27 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 11:49:05 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bc634f62cd094d3df5523d4fdd1649038a7e2635
Cr-Commit-Position: refs/heads/master@{#346889}

Powered by Google App Engine
This is Rietveld 408576698