Store parsed meta viewport even when it's currently disabled.

Store parsed meta viewport even when it's currently disabled.

By storing parsed meta viewport, we can apply it without reload when emulating mobile device.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201799

[dgozman, 2015-09-02 23:43:55]

dgozman@chromium.org changed reviewers:
+ bokan@chromium.org

[dgozman, 2015-09-02 23:43:56]

Hi David,

Could you please take a look? This patch passes all tests (see patchset 1) and
improves devtools user experience (less reloads). WDYT?

Thanks,
Dmitry

[bokan, 2015-09-03 15:02:06]

Hi Dmitry,

My only concern here is that this loses the differentiation between @viewport
and the viewport meta tag. We've made it so that @viewport support can be turned
on independent of viewport meta (e.g. if we want to turn it on for desktop
platforms). Removing this branch means that if @viewport is turned on, it'll get
clobbered by the viewport meta even if viewportMetaEnabled is off.

That said, @viewport shipping is uncertain and has been for a long time so the
improvement in UX is probably a good trade off for now. Please file a bug (you
can park it on me) about allowing disabling of viewport meta only and block bug
235457 on that. Otherwise, lgtm!

[dgozman, 2015-09-03 21:49:19]

On 2015/09/03 15:02:06, bokan wrote:
> Hi Dmitry,
> 
> My only concern here is that this loses the differentiation between @viewport
> and the viewport meta tag. We've made it so that @viewport support can be
turned
> on independent of viewport meta (e.g. if we want to turn it on for desktop
> platforms). Removing this branch means that if @viewport is turned on, it'll
get
> clobbered by the viewport meta even if viewportMetaEnabled is off.
> 
> That said, @viewport shipping is uncertain and has been for a long time so the
> improvement in UX is probably a good trade off for now. Please file a bug (you
> can park it on me) about allowing disabling of viewport meta only and block
bug
> 235457 on that. Otherwise, lgtm!

Thanks! All done, going to land this.

[dgozman, 2015-09-03 21:49:23]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-09-03 21:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/1328553003/#ps40001
(title: "rebase
")

[commit-bot: I haz the power, 2015-09-03 21:49:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328553003/40001

[commit-bot: I haz the power, 2015-09-03 21:58:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 21:58:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dgozman, 2015-09-03 22:14:43]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2015-09-03 22:14:43]

+pfeldman for OWNER stamp

[pfeldman, 2015-09-03 23:36:33]

lgtm

[dgozman, 2015-09-04 01:51:06]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-09-04 01:51:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328553003/40001

[commit-bot: I haz the power, 2015-09-04 04:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 04:42:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2015-09-04 05:32:07]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-09-04 05:32:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328553003/40001

[commit-bot: I haz the power, 2015-09-04 07:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 07:37:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2015-09-04 15:07:17]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-09-04 15:07:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328553003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328553003/40001

[commit-bot: I haz the power, 2015-09-04 16:20:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201799