Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: scripts/slave/recipes/gpu/download_and_test.py

Issue 132853003: Added support for properly building and running isolates in recipes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Only use isolates on Release bots for now; the Debug bots use the component build. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/gpu/download_and_test.py
diff --git a/scripts/slave/recipes/gpu/download_and_test.py b/scripts/slave/recipes/gpu/download_and_test.py
index 50bc384546df9c6275ba6c75e73f99f381bcea8f..95c326ff7dbf11259608eee6517164a64ce1a30b 100644
--- a/scripts/slave/recipes/gpu/download_and_test.py
+++ b/scripts/slave/recipes/gpu/download_and_test.py
@@ -35,17 +35,22 @@ def GenTests(api):
# Keep the additional properties in sync with the build_and_upload
# recipe in order to catch regressions.
for plat in ['win', 'mac', 'linux']:
- yield (
- api.test('%s_release' % plat) +
- api.properties.scheduled(
- build_config='Release',
- mastername='chromium.gpu.testing',
- buildername='%s tester' % plat,
- buildnumber=776,
- parent_buildername='%s builder' % plat,
- parent_buildnumber=571,
- parent_got_revision=160000,
- parent_got_webkit_revision=10000,
- ) +
- api.platform.name(plat)
- )
+ for flavor in ['Debug', 'Release']:
+ flavor_lower = flavor.lower()
+ yield (
+ api.test('%s_%s' % (plat, flavor_lower)) +
+ api.properties.scheduled(
+ build_config=flavor,
+ mastername='chromium.gpu.testing',
+ buildername='%s %s tester' % (plat, flavor_lower),
+ buildnumber=776,
+ parent_buildername='%s %s builder' % (plat, flavor_lower),
+ parent_buildnumber=571,
+ parent_got_revision=160000,
+ parent_got_webkit_revision=10000,
+ # These would ordinarily be generated during the build step.
+ swarm_hashes=dict(
+ gl_tests='6e784864abbeeff7499c15f75b904851d633c187'),
+ ) +
+ api.platform.name(plat)
+ )

Powered by Google App Engine
This is Rietveld 408576698