scripts/slave/recipes/gpu/build_and_upload.py - Issue 132853003: Added support for properly building and running isolates in recipes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/gpu/build_and_upload.py

Issue 132853003: Added support for properly building and running isolates in recipes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Only use isolates on Release bots for now; the Debug bots use the component build. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/gpu/api.py ('K') | « scripts/slave/recipes/gpu/build_and_test.expected/win_release_tryserver.json ('k') | scripts/slave/recipes/gpu/build_and_upload.expected/linux_debug.json » ('j') | scripts/slave/recipes/gpu/download_and_test.expected/win_release.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/gpu/build_and_upload.py

diff --git a/scripts/slave/recipes/gpu/build_and_upload.py b/scripts/slave/recipes/gpu/build_and_upload.py

index d9a5da0bdc03e6c24a75920239d63f426b1b176e..db99dcf1b7ecc3e789e27103240f480388cf42a8 100644

--- a/scripts/slave/recipes/gpu/build_and_upload.py

+++ b/scripts/slave/recipes/gpu/build_and_upload.py

@@ -26,12 +26,14 @@ def GenTests(api):

# Keep the additional properties in sync with the download_and_test

# recipe in order to catch regressions.

for plat in ['win', 'mac', 'linux']:

- yield (

- api.test('%s_release' % plat) +

- api.properties.scheduled(

- build_config='Release',

- mastername='chromium.gpu.testing',

- buildername='%s builder' % plat,

- buildnumber=571) +

- api.platform.name(plat)

- )

+ for flavor in ['Debug', 'Release']:

+ flavor_lower = flavor.lower()

+ yield (

+ api.test('%s_%s' % (plat, flavor_lower)) +

+ api.properties.scheduled(

+ build_config=flavor,

+ mastername='chromium.gpu.testing',

+ buildername='%s %s builder' % (plat, flavor_lower),

+ buildnumber=571) +

+ api.platform.name(plat)

+ )