Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 132853002: Show the path when a json file fails to parse. (Closed)

Created:
6 years, 11 months ago by Jeffrey Yasskin
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Show the path when a json file fails to parse. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/common/extensions/docs/server2/schema_util.py View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Jeffrey Yasskin
I bumped into this when I tried to preview a broken change to a .json ...
6 years, 11 months ago (2014-01-09 23:30:20 UTC) #1
not at google - send to devlin
lgtm
6 years, 11 months ago (2014-01-10 00:09:29 UTC) #2
Renato Mangini (chromium)
lgtm
6 years, 11 months ago (2014-01-10 00:14:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/132853002/1
6 years, 11 months ago (2014-01-10 00:27:57 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 06:19:00 UTC) #5
Message was sent while issue was closed. 
Change committed as 244105

Powered by Google App Engine
This is Rietveld 408576698