Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 1328503004: Fix VIEW_VC URL in codereview.settings. (Closed)

Created:
5 years, 3 months ago by tandrii(chromium)
Modified:
5 years, 3 months ago
Reviewers:
Mark Seaborn, Vadim Sh.
CC:
chromium-reviews, Markus (顧孟勤), Mark Seaborn
Base URL:
https://chromium.googlesource.com/linux-syscall-support@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M codereview.settings View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (1 generated)
tandrii(chromium)
5 years, 3 months ago (2015-09-04 20:53:06 UTC) #1
tandrii(chromium)
Committed patchset #1 (id:1) manually as cd0177fdded9be68578b856ac056ac89f713225b (presubmit successful).
5 years, 3 months ago (2015-09-04 20:53:23 UTC) #2
Vadim Sh.
lgtm
5 years, 3 months ago (2015-09-04 20:54:40 UTC) #3
Mark Seaborn
https://codereview.chromium.org/1328503004/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/1328503004/diff/1/codereview.settings#newcode4 codereview.settings:4: VIEW_VC: https://chromium.googlesource.com/external/linux-syscall-support/lss/+/ This isn't right for the new repo. ...
5 years, 3 months ago (2015-09-04 20:55:44 UTC) #5
Vadim Sh.
On 2015/09/04 20:55:44, Mark Seaborn wrote: > https://codereview.chromium.org/1328503004/diff/1/codereview.settings > File codereview.settings (right): > > https://codereview.chromium.org/1328503004/diff/1/codereview.settings#newcode4 ...
5 years, 3 months ago (2015-09-04 20:59:01 UTC) #6
tandrii(chromium)
On 2015/09/04 20:59:01, Vadim Sh. wrote: > On 2015/09/04 20:55:44, Mark Seaborn wrote: > > ...
5 years, 3 months ago (2015-09-04 20:59:22 UTC) #7
tandrii(chromium)
5 years, 3 months ago (2015-09-04 21:02:04 UTC) #8
Message was sent while issue was closed.
On 2015/09/04 20:59:22, tandrii(chromium) wrote:
> On 2015/09/04 20:59:01, Vadim Sh. wrote:
> > On 2015/09/04 20:55:44, Mark Seaborn wrote:
> > > https://codereview.chromium.org/1328503004/diff/1/codereview.settings
> > > File codereview.settings (right):
> > > 
> > >
> https://codereview.chromium.org/1328503004/diff/1/codereview.settings#newcode4
> > > codereview.settings:4: VIEW_VC:
> > > https://chromium.googlesource.com/external/linux-syscall-support/lss/+/
> > > This isn't right for the new repo.
> > > 
> > > It should be:
> > > https://chromium.googlesource.com/linux-syscall-support/+/
> > 
> > eh, lgmt-fail
> 
> eh, tbr-fail. Thanks for watchful eyes!

fix https://codereview.chromium.org/1328983002

Powered by Google App Engine
This is Rietveld 408576698