Update bookmarks/offline pages action bar menu item text dynamically

Update bookmarks/offline pages action bar menu item text dynamically

BUG=491352
Committed: https://crrev.com/20246cc4dc13de1790841fd4f83d8cecde10f049
Cr-Commit-Position: refs/heads/master@{#348718}

[jianli, 2015-09-09 23:27:54]

Patchset #1 (id:1) has been deleted

[jianli, 2015-09-09 23:28:33]

jianli@chromium.org changed reviewers:
+ kkimlabs@chromium.org, newt@chromium.org

[jianli, 2015-09-09 23:28:34]

newt for android_chrome_strings.grd

[newt (away), 2015-09-11 22:09:27]

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
(right):

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java:61:
boolean offlinePagesEnabled = OfflinePageBridge.isEnabled();
since the menu items already have default titles set in eb_action_bar_menu.xml,
I'd just modify the titles here if offlinePagesEnabled, e.g.

  if (offlinePagesEnabled) {
     
getMenu().findItem(R.id.search_menu_id).setTitle(R.string.offline_pages_action_bar_search);
      etc
  }

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1856: <message
name="IDS_OFFLINE_PAGES_ACTION_BAR_DELETE" desc="Button text for saved page
delete action on the offline pages action bar [CHAR-LIMIT=32]">
These descriptions need to be clear enough that translators can understand them.
Remember that translators are non-technical (they're linguists, not software
engineers), and aren't experts on Chrome features.

For example: "Button text to delete the selected webpages which are saved as
bookmarks.", etc

[jianli, 2015-09-11 22:19:28]

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
(right):

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java:61:
boolean offlinePagesEnabled = OfflinePageBridge.isEnabled();
On 2015/09/11 22:09:27, newt wrote:
> since the menu items already have default titles set in
eb_action_bar_menu.xml,
> I'd just modify the titles here if offlinePagesEnabled, e.g.
> 
>   if (offlinePagesEnabled) {
>      
>
getMenu().findItem(R.id.search_menu_id).setTitle(R.string.offline_pages_action_bar_search);
>       etc
>   }

Done.

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:1856: <message
name="IDS_OFFLINE_PAGES_ACTION_BAR_DELETE" desc="Button text for saved page
delete action on the offline pages action bar [CHAR-LIMIT=32]">
On 2015/09/11 22:09:27, newt wrote:
> These descriptions need to be clear enough that translators can understand
them.
> Remember that translators are non-technical (they're linguists, not software
> engineers), and aren't experts on Chrome features.
> 
> For example: "Button text to delete the selected webpages which are saved as
> bookmarks.", etc

Done.

[newt (away), 2015-09-11 23:32:36]

lgtm

[Kibeom Kim (inactive), 2015-09-14 15:23:16]

lgtm

[jianli, 2015-09-14 19:56:46]

The CQ bit was checked by jianli@chromium.org

[commit-bot: I haz the power, 2015-09-14 19:57:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1328483005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1328483005/40001

[commit-bot: I haz the power, 2015-09-14 20:54:48]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-09-14 20:55:47]

Patchset 2 (id:??) landed as
https://crrev.com/20246cc4dc13de1790841fd4f83d8cecde10f049
Cr-Commit-Position: refs/heads/master@{#348718}

[commit-bot: I haz the power, 2015-09-23 12:37:10]

Patchset 2 (id:??) landed as
https://crrev.com/20246cc4dc13de1790841fd4f83d8cecde10f049
Cr-Commit-Position: refs/heads/master@{#348718}