Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1328483005: Update bookmarks/offline pages action bar menu item text dynamically (Closed)

Created:
5 years, 3 months ago by jianli
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update bookmarks/offline pages action bar menu item text dynamically BUG=491352 Committed: https://crrev.com/20246cc4dc13de1790841fd4f83d8cecde10f049 Cr-Commit-Position: refs/heads/master@{#348718}

Patch Set 1 : Patch #

Total comments: 4

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jianli
newt for android_chrome_strings.grd
5 years, 3 months ago (2015-09-09 23:28:34 UTC) #3
newt (away)
https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java File chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java (right): https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java#newcode61 chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java:61: boolean offlinePagesEnabled = OfflinePageBridge.isEnabled(); since the menu items already ...
5 years, 3 months ago (2015-09-11 22:09:27 UTC) #4
jianli
https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java File chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java (right): https://codereview.chromium.org/1328483005/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java#newcode61 chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java:61: boolean offlinePagesEnabled = OfflinePageBridge.isEnabled(); On 2015/09/11 22:09:27, newt wrote: ...
5 years, 3 months ago (2015-09-11 22:19:28 UTC) #5
newt (away)
lgtm
5 years, 3 months ago (2015-09-11 23:32:36 UTC) #6
Kibeom Kim (inactive)
lgtm
5 years, 3 months ago (2015-09-14 15:23:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1328483005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1328483005/40001
5 years, 3 months ago (2015-09-14 19:57:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-14 20:54:48 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/20246cc4dc13de1790841fd4f83d8cecde10f049 Cr-Commit-Position: refs/heads/master@{#348718}
5 years, 3 months ago (2015-09-14 20:55:47 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20246cc4dc13de1790841fd4f83d8cecde10f049
Cr-Commit-Position: refs/heads/master@{#348718}

Powered by Google App Engine
This is Rietveld 408576698