Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: tests/BlitRowTest.cpp

Issue 132843002: Add REPORTF test macro. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: final rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/BitmapCopyTest.cpp ('k') | tests/DataRefTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/BlitRowTest.cpp
diff --git a/tests/BlitRowTest.cpp b/tests/BlitRowTest.cpp
index d0518bfb1d9bb38547cd13eecaa29c959043222c..1b0fad0105948215f0c5ce99a80020bfb169ab47 100644
--- a/tests/BlitRowTest.cpp
+++ b/tests/BlitRowTest.cpp
@@ -89,10 +89,8 @@ static bool check_color(const SkBitmap& bm, SkPMColor expect32,
uint32_t bad;
int x = proc(bm.getAddr(0, y), bm.width(), expect, &bad);
if (x >= 0) {
- SkString str;
- str.printf("BlitRow config=%s [%d %d] expected %x got %x",
- gConfigName[bm.config()], x, y, expect, bad);
- reporter->reportFailed(str);
+ ERRORF(reporter, "BlitRow config=%s [%d %d] expected %x got %x",
+ gConfigName[bm.config()], x, y, expect, bad);
return false;
}
}
@@ -252,10 +250,10 @@ static void test_diagonal(skiatest::Reporter* reporter) {
}
if (memcmp(dstBM0.getPixels(), dstBM1.getPixels(), dstBM0.getSize())) {
- SkString str;
- str.printf("Diagonal config=%s bg=0x%x dither=%d alpha=0x%x src=0x%x",
- gConfigName[gDstConfig[i]], bgColor, dither, alpha, c);
- reporter->reportFailed(str);
+ ERRORF(reporter, "Diagonal config=%s bg=0x%x dither=%d"
+ " alpha=0x%x src=0x%x",
+ gConfigName[gDstConfig[i]], bgColor, dither,
+ alpha, c);
}
}
}
« no previous file with comments | « tests/BitmapCopyTest.cpp ('k') | tests/DataRefTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698