Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: tests/PathCoverageTest.cpp

Issue 132843002: Add REPORTF test macro. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: factor Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/MathTest.cpp ('k') | tests/SortTest.cpp » ('j') | tests/Test.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/PathCoverageTest.cpp
diff --git a/tests/PathCoverageTest.cpp b/tests/PathCoverageTest.cpp
index 25b5fd1c09c905658285c8f72ebe45070a455d72..7153550523eabbcd1282336647bc280a88b09d60 100644
--- a/tests/PathCoverageTest.cpp
+++ b/tests/PathCoverageTest.cpp
@@ -137,14 +137,12 @@ static bool one_d_pe(const int* array, const unsigned int count,
(estimatedCount <= 2 * computedCount);
if (!isAccurate) {
- SkString errorDescription;
- errorDescription.printf(
- "Curve from %.2f %.2f through %.2f %.2f to %.2f %.2f "
- "computes %d, estimates %d\n",
- path[0].fX, path[0].fY, path[1].fX, path[1].fY,
- path[2].fX, path[2].fY, computedCount, estimatedCount);
+ REPORTF(reporter,
+ ("Curve from %.2f %.2f through %.2f %.2f to %.2f %.2f "
+ "computes %d, estimates %d\n",
+ path[0].fX, path[0].fY, path[1].fX, path[1].fY,
+ path[2].fX, path[2].fY, computedCount, estimatedCount));
numErrors++;
- reporter->reportFailed(errorDescription);
}
}
« no previous file with comments | « tests/MathTest.cpp ('k') | tests/SortTest.cpp » ('j') | tests/Test.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698